Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow Google guidelines to use Google OAuth #1588

Merged
merged 3 commits into from
May 11, 2021
Merged

Follow Google guidelines to use Google OAuth #1588

merged 3 commits into from
May 11, 2021

Conversation

tamo
Copy link
Contributor

@tamo tamo commented Sep 1, 2020

Tamotsu Takahashi added 3 commits September 1, 2020 20:54
If you use Google OAuth, you need to add Privacy Policy to the top.
https://support.google.com/cloud/answer/9110914#all-apps-zippy
#1582 (comment)

Signed-off-by: Tamotsu Takahashi <ttakah@gmail.com>
#1582

Signed-off-by: Tamotsu Takahashi <ttakah@gmail.com>
Signed-off-by: Tamotsu Takahashi <ttakah@gmail.com>
@Yukaii Yukaii temporarily deployed to codimd-google-oauth-ver-x1b9q2 September 3, 2020 08:55 Inactive
@Yukaii Yukaii added this to the 2.4.0 milestone May 11, 2021
Copy link
Member

@jackycute jackycute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tamo

@jackycute jackycute merged commit 6585976 into hackmdio:develop May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon for "Sign in via Google" is not compliant with "Sign-In Branding Guidelines"
3 participants