Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xss issue for image lightbox #1632

Merged
merged 2 commits into from
Dec 25, 2020
Merged

Fix xss issue for image lightbox #1632

merged 2 commits into from
Dec 25, 2020

Conversation

Yukaii
Copy link
Member

@Yukaii Yukaii commented Dec 21, 2020 •
edited
Loading

Fix #1631

@Yukaii
Escape attributes in lightbox image
26a2c74 
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii temporarily deployed to codimd-bugfix-fix-xss-i-qfov6f December 21, 2020 06:13 Inactive
@Yukaii Yukaii linked an issue Dec 21, 2020 that may be closed by this pull request
XSS in lightbox feature #1631
Closed
@Yukaii
Fix fretboard title xss issue
5fee551 
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii temporarily deployed to codimd-bugfix-fix-xss-i-qfov6f December 21, 2020 06:26 Inactive
jackycute
jackycute approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@jackycute jackycute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yukaii Yukaii added this to the Next milestone Dec 21, 2020
@Yukaii Yukaii merged commit 48f3be8 into develop Dec 25, 2020
@Yukaii Yukaii deleted the bugfix/fix-xss-in-lightbox-image-attribute branch December 25, 2020 08:21
@Yukaii Yukaii modified the milestones: Next, 2.3.0 Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackycute jackycute jackycute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

XSS in lightbox feature
2 participants
@Yukaii @jackycute