Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vimeo won't show up due to the jsonp callback data unable be parsed with jQuery #1652

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

jackycute
Copy link
Member

The JSONP callback data from vimeo is prepend with /**/ which can't be parsed by jQuery.

@Yukaii Yukaii temporarily deployed to codimd-bugfix-fix-vimeo-wvdm03 January 21, 2021 06:22 Inactive
@jackycute jackycute requested a review from Yukaii January 21, 2021 06:33
…sed with jQuery

Signed-off-by: Max Wu <jackymaxj@gmail.com>
Signed-off-by: Max Wu <jackymaxj@gmail.com>
@jackycute jackycute force-pushed the bugfix/fix-vimeo-jsonp-callback branch from 2434c50 to 2b9affb Compare January 21, 2021 06:35
@Yukaii Yukaii temporarily deployed to codimd-bugfix-fix-vimeo-wvdm03 January 21, 2021 06:35 Inactive
@Yukaii Yukaii added this to the Next milestone Jan 21, 2021
@Yukaii Yukaii merged commit 14e93fd into develop Jan 25, 2021
@Yukaii Yukaii deleted the bugfix/fix-vimeo-jsonp-callback branch January 25, 2021 07:00
@Yukaii Yukaii modified the milestones: Next, 2.4.0 May 11, 2021
edgarogh pushed a commit to WartaPoirier-corp/codimd that referenced this pull request Jun 7, 2022
Signed-off-by: Renovate Bot <bot@renovateapp.com>

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants