Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - add Music section and move abc abd fretboard to this section #1715

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

brunetton
Copy link

I was wondering for a while why ABC music notation is in placed under "UML diagrams" section.

I created a dedicated Music section and put ABC and fretboard onto this section

@jackycute
Copy link
Member

Hi @brunetton,

Thanks for the PR and it makes sense.
Could you sign the commit? https://github.com/hackmdio/codimd/blob/develop/CONTRIBUTING.md#sign-your-work

…section

Signed-off-by: Bruno Duyé <brunetton@brunetton.org>
@brunetton
Copy link
Author

Hi @brunetton,

Thanks for the PR and it makes sense. Could you sign the commit? https://github.com/hackmdio/codimd/blob/develop/CONTRIBUTING.md#sign-your-work

Done !
And shame on me for not have read the CONTRIBUTING.md file 🤫

edgarogh pushed a commit to WartaPoirier-corp/codimd that referenced this pull request Jun 7, 2022
@jackycute
Copy link
Member

Thanks @brunetton

@jackycute jackycute merged commit 21345ed into hackmdio:develop Jan 13, 2023
@stanley2058 stanley2058 mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants