Update minimum required node.js version to v12 with npm package dependencies #1799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the node.js and npm dependencies didn't get update for a while, node.js v10 is EoL at 2021-04-30, and there could be a lot of security vulnerabilities since the last release, especially for those using pre-built Docker image on Docker Hub.
The idea here, is try to increase the baseline of the node.js and npm packages "a little bit", and ideally will update to node.js v18, because both of node.js v14 & v16 will reach EoL this year, node.js v12 is EoL at 2022-04-30 last year.
As I can't guarantee how much I can contribute, each PR won't be large, so that we can get it reviewed and merged in a more agile way ;)
Currently,
npm run test
is the assurance of the update not breaking things, please let me know if that's not enough. Thanks.Reference:
Prompt message from
npm install
before the update:Prompt message from
npm install
after the update: