chore: update docker-compose.yml with build instructions for codimd service #1917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervice Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the docker-compose configuration for the codimd service by adding instructions for building the image.
- Adds commented instructions to trigger a docker-compose build
- Adds commented build configuration and args for runtime and buildpack versions
Comments suppressed due to low confidence (2)
deployments/docker-compose.yml:15
- [nitpick] Consider moving detailed build instructions and related configuration comments to a dedicated documentation file (e.g., README) to keep the deployment file concise.
# Using the following command to trigger the build
deployments/docker-compose.yml:20
- [nitpick] If these build arguments are intended for future use, include a brief note on their purpose and when to enable them, so developers understand the context without needing to search elsewhere.
# args:
jackycute
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.