Skip to content

refactor: migrate RevealMarkdown to ES module imports #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
+20 −11
Merged

refactor: migrate RevealMarkdown to ES module imports #1941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions public/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2749,13 +2749,14 @@ function updateViewInner () {
delete md.metaError
var rendered = md.render(value)
if (md.meta.type && md.meta.type === 'slide') {
var RevealMarkdown = require('./reveal-markdown').default
var slideOptions = {
separator: '^(\r\n?|\n)---(\r\n?|\n)$',
verticalSeparator: '^(\r\n?|\n)----(\r\n?|\n)$'
}
var slides = window.RevealMarkdown.slidify(editor.getValue(), slideOptions)
var slides = RevealMarkdown.slidify(editor.getValue(), slideOptions)
ui.area.markdown.html(slides)
window.RevealMarkdown.initialize()
RevealMarkdown.initialize()
// prevent XSS
ui.area.markdown.html(preventXSS(ui.area.markdown.html()))
ui.area.markdown.addClass('slides')
Expand Down
5 changes: 3 additions & 2 deletions public/js/pretty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint-env browser, jquery */
/* global refreshView */
import RevealMarkdown from './reveal-markdown'

import {
autoLinkify,
Expand Down Expand Up @@ -35,9 +36,9 @@ if (md.meta.type && md.meta.type === 'slide') {
separator: '^(\r\n?|\n)---(\r\n?|\n)$',
verticalSeparator: '^(\r\n?|\n)----(\r\n?|\n)$'
}
const slides = window.RevealMarkdown.slidify(text, slideOptions)
const slides = RevealMarkdown.slidify(text, slideOptions)
markdown.html(slides)
window.RevealMarkdown.initialize()
RevealMarkdown.initialize()
// prevent XSS
markdown.html(preventXSS(markdown.html()))
markdown.addClass('slides')
Expand Down
11 changes: 11 additions & 0 deletions public/js/reveal-markdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,3 +354,14 @@ import { md } from './extra'
slidify: slidify
}
}))

// ES Module export for modern imports
const RevealMarkdownAPI = (function () {
if (typeof window !== 'undefined' && window.RevealMarkdown) {
return window.RevealMarkdown
}
// Fallback - shouldn't happen in normal usage
return {}
})()

export default RevealMarkdownAPI
4 changes: 3 additions & 1 deletion public/js/slide.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
/* eslint-env browser, jquery */
/* global serverurl, Reveal, RevealMarkdown */
/* global serverurl, Reveal */

import RevealMarkdown from './reveal-markdown'

import { preventXSS } from './render'
import { md, updateLastChange, removeDOMEvents, finishView } from './extra'
Expand Down
6 changes: 0 additions & 6 deletions webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,6 @@ module.exports = {
'script-loader!ot',
'flowchart.js',
'imports-loader?Raphael=raphael!js-sequence-diagrams',
'expose-loader?RevealMarkdown!reveal-markdown',
path.join(__dirname, 'public/js/index.js')
],
'index-styles': [
Expand Down Expand Up @@ -323,7 +322,6 @@ module.exports = {
'script-loader!vega-lite',
'script-loader!vega-embed',
'expose-loader?io!socket.io-client',
'expose-loader?RevealMarkdown!reveal-markdown',
'expose-loader?L!leaflet',
path.join(__dirname, 'public/js/index.js')
],
Expand All @@ -332,7 +330,6 @@ module.exports = {
'regenerator-runtime/runtime',
'flowchart.js',
'imports-loader?Raphael=raphael!js-sequence-diagrams',
'expose-loader?RevealMarkdown!reveal-markdown',
path.join(__dirname, 'public/js/pretty.js')
],
'pretty-styles': [
Expand Down Expand Up @@ -363,7 +360,6 @@ module.exports = {
'script-loader!vega',
'script-loader!vega-lite',
'script-loader!vega-embed',
'expose-loader?RevealMarkdown!reveal-markdown',
'expose-loader?L!leaflet',
path.join(__dirname, 'public/js/pretty.js')
],
Expand All @@ -373,7 +369,6 @@ module.exports = {
'bootstrap-tooltip',
'flowchart.js',
'imports-loader?Raphael=raphael!js-sequence-diagrams',
'expose-loader?RevealMarkdown!reveal-markdown',
path.join(__dirname, 'public/js/slide.js')
],
'slide-styles': [
Expand Down Expand Up @@ -408,7 +403,6 @@ module.exports = {
'script-loader!vega-lite',
'script-loader!vega-embed',
'expose-loader?Reveal!reveal.js',
'expose-loader?RevealMarkdown!reveal-markdown',
'expose-loader?L!leaflet',
path.join(__dirname, 'public/js/slide.js')
]
Expand Down