This repository was archived by the owner on Jul 6, 2019. It is now read-only.
Fix for flash clock config at frequency 20<x<=40 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, I'm surprised there wasn't a warning for unreachable code. Any chance you can reply with a link to the relevant datasheet, lpc17xx isn't my platform. |
|
http://www.nxp.com/documents/user_manual/UM10360.pdf Function looks correct now to me. |
|
Thanks. |
hacknbot
added a commit
that referenced
this pull request
Jul 17, 2014
Fix for flash clock config at frequency 20<x<=40 Reviewed-by: bharrisau
|
Thanks for finding that! PS: I filed rust-lang/rust#15736 for rust, I wonder if the compiler could do anything to prevent this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original code had a typo.