Split mentions and tagging from the actual notes#14
Closed
ImTheKai wants to merge 1 commit intohackorum-dev:mainfrom
Closed
Split mentions and tagging from the actual notes#14ImTheKai wants to merge 1 commit intohackorum-dev:mainfrom
ImTheKai wants to merge 1 commit intohackorum-dev:mainfrom
Conversation
Signed-off-by: Kai Wagner <kai.wagner@percona.com>
Collaborator
Author
|
@dutow Let me know if this makes any sense or what you do think about this. |
Collaborator
Author
Collaborator
|
If we do this, does it still make sense to keep them together with notes? Would it make sense to simply add a mention without a note (ping somebody?), or tag something without a note? |
Collaborator
Author
Yeah makes sense. Let me think how this could look like. |
Collaborator
Author
|
Thinking about it again, and trying to rearrange the UI, I really wonder if we want to have that. The possibility to tag and mention within the Note itself, seems way better and easier instead. So I would rather give up on markdown parsing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This splits the mentions and tagging into subitems/input boxes, which allows us later to support markdown or other stuff for the notes directly, as these are seperate.