Add attached patches to message view#16
Closed
AndersAstrand wants to merge 1 commit intohackorum-dev:mainfrom
Closed
Add attached patches to message view#16AndersAstrand wants to merge 1 commit intohackorum-dev:mainfrom
AndersAstrand wants to merge 1 commit intohackorum-dev:mainfrom
Conversation
Also let the user expand/collapse them by clicking.
AndersAstrand
force-pushed
the
show-attached-patches
branch
from
9b64945 to
232159c
Compare
dutow
reviewed
Dec 18, 2025
| span.filename = attachment.file_name | ||
| span.content-type = attachment.content_type if attachment.content_type | ||
| - if attachment.patch? | ||
| details class="attachment" |
Collaborator
There was a problem hiding this comment.
these class="<x>" lines could all be like details.attachment
Collaborator
Author
There was a problem hiding this comment.
Thanks! I haven't used this template language before. Good to know! 🙂
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also let the user expand/collapse them by clicking.
This is just the fundamentals, we need to do more with it before it's useful. If I pick this up again I'll try to use highlight.js to add some colors to the diffs and some css to make it all look good.