Skip to content

this should make swipes register reliably on mobile as currently its not always recognizing #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImTheKai merged 1 commit into from
Feb 10, 2026
Merged

this should make swipes register reliably on mobile as currently its not always recognizing #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 62 additions & 6 deletions app/javascript/controllers/swipe_nav_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,18 @@ export default class extends Controller {
this.onPointerDown = this.onPointerDown.bind(this)
this.onPointerMove = this.onPointerMove.bind(this)
this.onPointerUp = this.onPointerUp.bind(this)
this.onTouchStart = this.onTouchStart.bind(this)
this.onTouchMove = this.onTouchMove.bind(this)
this.onTouchEnd = this.onTouchEnd.bind(this)
window.addEventListener("pointerdown", this.onPointerDown, { passive: true })
window.addEventListener("touchstart", this.onTouchStart, { passive: true })
}

disconnect() {
window.removeEventListener("pointerdown", this.onPointerDown, { passive: true })
window.removeEventListener("touchstart", this.onTouchStart, { passive: true })
this.detachTrackingListeners()
this.detachTouchTrackingListeners()
}

onPointerDown(event) {
Expand All @@ -23,6 +29,7 @@ export default class extends Controller {
if (event.button && event.button !== 0) return
if (this.shouldIgnoreTarget(event.target)) return

this.usingPointer = true
this.tracking = true
this.pointerId = event.pointerId
this.startX = event.clientX
Expand Down Expand Up @@ -51,8 +58,63 @@ export default class extends Controller {

this.tracking = false
this.pointerId = null
this.usingPointer = false
this.detachTrackingListeners()

this.maybeNavigate(elapsed, deltaX, deltaY)
}

detachTrackingListeners() {
window.removeEventListener("pointermove", this.onPointerMove, { passive: true })
window.removeEventListener("pointerup", this.onPointerUp, { passive: true })
window.removeEventListener("pointercancel", this.onPointerUp, { passive: true })
}

onTouchStart(event) {
if (this.usingPointer) return
if (!event.touches || event.touches.length !== 1) return
if (this.shouldIgnoreTarget(event.target)) return

const touch = event.touches[0]
this.touchTracking = true
this.startX = touch.clientX
this.startY = touch.clientY
this.startTime = performance.now()
this.lastX = touch.clientX
this.lastY = touch.clientY

window.addEventListener("touchmove", this.onTouchMove, { passive: true })
window.addEventListener("touchend", this.onTouchEnd, { passive: true })
window.addEventListener("touchcancel", this.onTouchEnd, { passive: true })
}

onTouchMove(event) {
if (!this.touchTracking || !event.touches || event.touches.length !== 1) return
const touch = event.touches[0]
this.lastX = touch.clientX
this.lastY = touch.clientY
}

onTouchEnd() {
if (!this.touchTracking) return

const elapsed = performance.now() - this.startTime
const deltaX = this.lastX - this.startX
const deltaY = this.lastY - this.startY

this.touchTracking = false
this.detachTouchTrackingListeners()

this.maybeNavigate(elapsed, deltaX, deltaY)
}

detachTouchTrackingListeners() {
window.removeEventListener("touchmove", this.onTouchMove, { passive: true })
window.removeEventListener("touchend", this.onTouchEnd, { passive: true })
window.removeEventListener("touchcancel", this.onTouchEnd, { passive: true })
}

maybeNavigate(elapsed, deltaX, deltaY) {
if (elapsed > SWIPE_TIME_MS) return
if (Math.abs(deltaX) < SWIPE_DISTANCE_PX) return
if (Math.abs(deltaX) < Math.abs(deltaY) * SWIPE_AXIS_RATIO) return
Expand All @@ -64,12 +126,6 @@ export default class extends Controller {
}
}

detachTrackingListeners() {
window.removeEventListener("pointermove", this.onPointerMove, { passive: true })
window.removeEventListener("pointerup", this.onPointerUp, { passive: true })
window.removeEventListener("pointercancel", this.onPointerUp, { passive: true })
}

shouldIgnoreTarget(target) {
if (!target) return true
if (target.closest("input, textarea, select, [contenteditable='true']")) return true
Expand Down