Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Issue #51 - Buttons for bans #109

Merged

Conversation

janssensjelle
Copy link
Contributor

@janssensjelle janssensjelle commented Nov 4, 2024

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

This PR implements the changes from Issue #51 . Buttons will be added for the ban actions (approve, dispute, deny). The original slash commands will still work. After actioning, the buttons will be disabled.

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Example screenshots

Sorry, something went wrong.

@janssensjelle janssensjelle changed the title Feature/issue 51 buttons for bans Issue #51 - [FEATURE] Buttons for bans Nov 4, 2024
@janssensjelle janssensjelle changed the title Issue #51 - [FEATURE] Buttons for bans [FEATURE] Issue #51 - Buttons for bans Nov 4, 2024

Verified

This commit was signed with the committer’s verified signature. The key has expired.
meatballhat Dan Buch

Verified

This commit was signed with the committer’s verified signature. The key has expired.
meatballhat Dan Buch

Verified

This commit was signed with the committer’s verified signature. The key has expired.
meatballhat Dan Buch
@janssensjelle janssensjelle force-pushed the feature/issue-51-buttons-for-bans branch from bbaf6d0 to 2dde221 Compare November 5, 2024 04:24
@janssensjelle janssensjelle marked this pull request as ready for review November 5, 2024 11:42
@0xEmma
Copy link
Collaborator

0xEmma commented Nov 13, 2024

lgtm

Copy link
Contributor

@dimoschi dimoschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much cleaner and more sophisticated! Nice work

@dimoschi dimoschi merged commit 584b4ff into hackthebox:main Nov 13, 2024
@janssensjelle
Copy link
Contributor Author

LGTM, much cleaner and more sophisticated! Nice work

Thank you

@janssensjelle janssensjelle deleted the feature/issue-51-buttons-for-bans branch November 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants