Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Solution for /unmute command failing #111

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

janssensjelle
Copy link
Contributor

@janssensjelle janssensjelle commented Nov 8, 2024

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

When an /unmute command is actioned, the unmute will only remove the muted role. The actual timeout is not removed. This PR fixes that. Might also cause improvement for #49

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Unmute fail

@janssensjelle janssensjelle changed the title Unmute command failing Solution for /unmute command failing Nov 8, 2024
@janssensjelle janssensjelle changed the title Solution for /unmute command failing [BUGFIX] Solution for /unmute command failing Nov 8, 2024
@makelarisjr makelarisjr merged commit e853739 into hackthebox:main Nov 9, 2024
@janssensjelle janssensjelle deleted the bugfix/unmute-command branch November 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants