Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] - Join date is always Left #113

Conversation

janssensjelle
Copy link
Contributor

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

The join date for a /history was always left due to it unconditionally being true

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Add any other context or screenshots here.

@janssensjelle
Copy link
Contributor Author

Current:

Screenshot 2024-11-12 at 15 23 41

Future (dates are from test environment):

Screenshot 2024-11-12 at 15 24 23

@makelarisjr makelarisjr merged commit cee92a9 into hackthebox:main Nov 12, 2024
@janssensjelle janssensjelle deleted the bugfix/join-date-left-unconditionally branch November 12, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants