Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Evidence field for /kick #115

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

janssensjelle
Copy link
Contributor

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

This PR adds the evidence option to the /kick command.
I have refactored the code a bit.

  • moved the add_evicence_note to the ban helper
  • Altered ban function + tests
  • Added a test case for kicking a user and adding a note

I received a false positive from the lint saying the arrow import is unused, but this is false.

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

… evidence to kick command. Altered ban tests and added a kick test

Signed-off-by: Jelle Janssens <janssens_jelle@telenet.be>
Co-authored-by: Dimosthenis Schizas <dimoschi@gmail.com>
@dimoschi dimoschi merged commit 9e7d1b0 into hackthebox:main Nov 21, 2024
dimoschi added a commit that referenced this pull request Nov 22, 2024
[BUGFIX] Fix failing test due to missing parenthesis from PR #115
@janssensjelle janssensjelle deleted the feature/add-evidence-to-kick branch November 22, 2024 11:12
@janssensjelle janssensjelle restored the feature/add-evidence-to-kick branch November 22, 2024 11:12
@janssensjelle janssensjelle deleted the feature/add-evidence-to-kick branch November 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants