Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - show evidence in ban approval view #120

Conversation

janssensjelle
Copy link
Contributor

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

This will alter the ban approval view a bit by adding the evidence field from #114 in the overview. Also fixes the failing tests due to a missing mock from the evidence field.
Screenshot 2024-11-21 at 20 28 35

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Signed-off-by: Jelle Janssens <janssens_jelle@telenet.be>
Signed-off-by: Jelle Janssens <janssens_jelle@telenet.be>
Signed-off-by: Jelle Janssens <janssens_jelle@telenet.be>
Signed-off-by: Jelle Janssens <janssens_jelle@telenet.be>
… evidence to kick command. Altered ban tests and added a kick test

Signed-off-by: Jelle Janssens <janssens_jelle@telenet.be>
@janssensjelle
Copy link
Contributor Author

Closing this PR will reopen new one when fixed correctly

@janssensjelle janssensjelle deleted the feature/evidence-in-ban-approval-view branch November 22, 2024 11:12
@janssensjelle janssensjelle restored the feature/evidence-in-ban-approval-view branch November 22, 2024 13:55
@janssensjelle janssensjelle deleted the feature/evidence-in-ban-approval-view branch November 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant