Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add evidence field in the ban request overview #123

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

janssensjelle
Copy link
Contributor

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

This feature will add the evidence field in the ban request overview. Tests were altered accordingly.

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Evidence provided

Plain text
Screenshot 2024-11-22 at 13 31 04

With discord link
Screenshot 2024-11-22 at 13 37 12

No evidence provided

Screenshot 2024-11-22 at 13 31 48

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.00%. Comparing base (76ce1b1) to head (a6ae450).
Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
tests/src/cmds/core/test_ban.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   67.57%   67.00%   -0.57%     
==========================================
  Files          67       68       +1     
  Lines        3380     3525     +145     
==========================================
+ Hits         2284     2362      +78     
- Misses       1096     1163      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dimoschi dimoschi merged commit 74ae3e0 into hackthebox:main Nov 22, 2024
3 checks passed
@janssensjelle janssensjelle deleted the feature/ban-view-add-evidence branch November 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants