Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spoilers are directed to the Jira #125

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

ToxicBiohazard
Copy link
Contributor

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

Describe your changes here and explain why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

The spoilers are now directed to the Jira.

Tests are authored by Jelle

Co-authored-by: Jelle Janssens <janssens_jelle@telenet.be>
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.34%. Comparing base (af88953) to head (f914e1d).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
src/cmds/core/other.py 83.33% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #125       +/-   ##
===========================================
- Coverage   67.21%   51.34%   -15.87%     
===========================================
  Files          68       41       -27     
  Lines        3547     2339     -1208     
===========================================
- Hits         2384     1201     -1183     
+ Misses       1163     1138       -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.test.env Outdated Show resolved Hide resolved
Copy link
Contributor

@dimoschi dimoschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss-clicked please change the ENV in .test.env. Other than that good work, thank you!

@ToxicBiohazard
Copy link
Contributor Author

I caught the issue. don't merge yet.

@ToxicBiohazard
Copy link
Contributor Author

Should be good now.

Copy link
Contributor

@dimoschi dimoschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@dimoschi dimoschi merged commit c8b9568 into hackthebox:main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants