-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spoilers are directed to the Jira #125
Conversation
Tests are authored by Jelle Co-authored-by: Jelle Janssens <janssens_jelle@telenet.be>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
===========================================
- Coverage 67.21% 51.34% -15.87%
===========================================
Files 68 41 -27
Lines 3547 2339 -1208
===========================================
- Hits 2384 1201 -1183
+ Misses 1163 1138 -25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss-clicked please change the ENV in .test.env
. Other than that good work, thank you!
I caught the issue. don't merge yet. |
Should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that apply.Proposed changes
Describe your changes here and explain why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.
Checklist
Put an
x
in the boxes that apply.doc.
Additional context
The spoilers are now directed to the Jira.