Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor webhook authorization in server.py using hmac #3

Merged
merged 2 commits into from
May 2, 2023

Conversation

dimoschi
Copy link
Contributor

@dimoschi dimoschi commented May 2, 2023

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).
  • Documentation Update (if none of the other choices applies).

Proposed changes

Describe your changes here and explain why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.

Checklist

Put an x in the boxes that apply.

  • I have read and followed the CONTRIBUTING.md
    doc.
  • Lint and unit tests pass locally with my changes.
  • I have added the necessary documentation (if appropriate).

Additional context

Add any other context or screenshots here.

@dimoschi dimoschi requested a review from makelarisjr as a code owner May 2, 2023 21:37
@dimoschi dimoschi linked an issue May 2, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf5925d) 61.78% compared to head (efbe9df) 61.78%.

❗ Current head efbe9df differs from pull request most recent head e8bbd2a. Consider uploading reports for the commit e8bbd2a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   61.78%   61.78%           
=======================================
  Files          56       56           
  Lines        2999     2999           
=======================================
  Hits         1853     1853           
  Misses       1146     1146           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@makelarisjr makelarisjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@makelarisjr makelarisjr merged commit 9b3faa8 into main May 2, 2023
@dimoschi dimoschi deleted the 2-potential-timing-attack branch May 2, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential timing attack
3 participants