Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Makefile #28

Merged
merged 13 commits into from
Aug 6, 2023
Merged

Added Makefile #28

merged 13 commits into from
Aug 6, 2023

Conversation

eniayomi
Copy link
Contributor

@eniayomi eniayomi commented Aug 5, 2023

Describe your changes

  • Added a Makefile to allow generating eecutables for different operating systems(windows, Mac OS, Linux). I also updated the pipeline so it creates all executables and uploads them so its downloadable from the artifacts section.
Screenshot 2023-08-05 at 12 05 06
  • Currently github uploads as one single zip for all executables. Also this executables can be added also when a new release is created. This process can be automated too

  • Finally, Added a PR template

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • I have updated the version in Makefile

@hacktivist123
Copy link
Owner

hacktivist123 commented Aug 5, 2023

This is great, thanks for your contribution, @eniayomi I have one question as I'm not familiar with how this works. How do I access the executables after the workflow runs?

@eniayomi
Copy link
Contributor Author

eniayomi commented Aug 6, 2023

This is great, thanks for your contribution, @eniayomi I have one question as I'm not familiar with how this works. How do I access the executables after the workflow runs?

Click on the workflow,
Screenshot 2023-08-06 at 14 34 49

Then towards the bottom, you will see the arifacts section
Screenshot 2023-08-06 at 14 35 40

@hacktivist123
Copy link
Owner

This is great, thanks for your contribution, @eniayomi I have one question as I'm not familiar with how this works. How do I access the executables after the workflow runs?

Click on the workflow, Screenshot 2023-08-06 at 14 34 49

Then towards the bottom, you will see the arifacts section Screenshot 2023-08-06 at 14 35 40

awesome, thanks for the awesome work man, i just changed the version name as we are currently in 1.0.3.

@hacktivist123 hacktivist123 merged commit 3adb7e3 into hacktivist123:main Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants