Skip to content

Commit

Permalink
fix: disable exactOptionalPropertyTypes TypeScript option
Browse files Browse the repository at this point in the history
This setting is causing problems with one of `react-aria`'s
dependencies, and we've found it to be probably more annoying than
it's worth anyway, on balance.

Signed-off-by: Drew Hess <src@drewhess.com>
  • Loading branch information
dhess committed Jul 13, 2023
1 parent 51cc92a commit 5becb05
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion src/components/TreeReactFlow/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1253,7 +1253,7 @@ export const ReactFlowSafe = <
// the tree in order to perform actions on them.
elementsSelectable: false,
onNodeClick: (e, n) => {
"onNodeClick" in p &&
p.onNodeClick &&
p.onNodeClick(
e,
// This cast is safe because `N` is also the type of elements of the `nodes` field.
Expand Down
1 change: 0 additions & 1 deletion tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"alwaysStrict": true,
"exactOptionalPropertyTypes": true,
"noFallthroughCasesInSwitch": true,
"noImplicitAny": true,
"noImplicitOverride": true,
Expand Down

0 comments on commit 5becb05

Please sign in to comment.