Make use of using declarations in our vendored tidy
#1187
Comments
dhess
added a commit
that referenced
this issue
May 4, 2024
In this commit, we remove the `@zxch3n/tidy` dependency in favor of our own hard fork `@hackworthltd/tidyt-wasm` and a bit of vendoring for the non-Wasm bits. Specifically: 1. Drop `@zxch3n/tidy`. 2. Add a `@hackworthltd/tidyt-wasm` dependency, which now provides the Wasm bits that `@zxch3n/tidy` previously did. 3. Vendor `tidy.ts` from `@zxch3n/tidy`, as this is the only bit of upstream that we need. (We also use `dispose.ts`, but that itself was vendored in `@zxch3n/tidy`, and we expect it's temporary, anyway; see #1187.) 4. Use a Vite plugin for loading Wasm modules, so we can drop the boilerplate `initWasm` step that `@zxch3n/tidy` requires. Note that we vendor `tidy.ts` from this upstream commit: zxch3n/tidy@54382fa Our vendored `tidy.ts` is nearly identical to upstream at that commit, except that a) we don't need the `initWasm` stuff, as explained above, and b) we pull the `visit` function into the file as well. (The latter lives in `utils.ts` in the upstream project.) Note that there are a few TypeScript errors in our vendored `tidy.ts`. These errors are also present in the upstream version, but they do not manifest in the running code, which appears to work identically to the upstream code it replaces. We will fix these TypeScript errors in a subsequent commit, but not here, as I want the diff vs. upstream to be as clean as possible in this initial vendoring commit. Fixes #1186. Signed-off-by: Drew Hess <src@drewhess.com>
|
I don't think we can easily use |
dhess
added a commit
that referenced
this issue
May 4, 2024
Fixes #1187 Signed-off-by: Drew Hess <src@drewhess.com>
dhess
added a commit
that referenced
this issue
May 4, 2024
Fixes #1187 Signed-off-by: Drew Hess <src@drewhess.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Upstream
tidyuses the TypeScript “disposable” pattern by copy-pasting some boilerplate-y code: https://github.com/zxch3n/tidy/blob/master/src/dispose.tsIf I understand correctly, this pattern is built into (in preview form) recent versions of TypeScript: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-2.html. It can be enabled as follows:
{ "compilerOptions": { "target": "es2022", "lib": ["es2022", "esnext.disposable", "dom"] } }Assuming we implement #1186, we should look into enabling this and refactoring the vendored code to use it.
The text was updated successfully, but these errors were encountered: