Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier in nixpkgs is out of sync/broken #138

Open
dhess opened this issue Nov 15, 2021 · 2 comments
Open

prettier in nixpkgs is out of sync/broken #138

dhess opened this issue Nov 15, 2021 · 2 comments
Assignees
Labels
blocked/upstream ❌ Blocked by upstream issue bug 🐞 A confirmed bug tracking This is a tracking issue

Comments

@dhess
Copy link
Member

dhess commented Nov 15, 2021

See:

This is causing problems in our CI, because we can't use the Yarn-installed version of prettier in the pre-commit-hooks check, and we can't use the pinned nixpkgs version because of the breakage.

Therefore, in #136, I disabled the pre-commit-hooks prettier check. We'll need to re-enable it at a later date.

@dhess dhess self-assigned this Nov 15, 2021
@dhess dhess added blocked/upstream ❌ Blocked by upstream issue bug 🐞 A confirmed bug tracking This is a tracking issue labels Nov 15, 2021
dhess added a commit that referenced this issue Nov 15, 2021
@dhess
Copy link
Member Author

dhess commented Jan 8, 2022

nodejs 16.x is still broken in nixpkgs, nearly 2 months after this bug was filed upstream: NixOS/nixpkgs#145432 (comment)

I note this here only to support the argument that perhaps Nix isn't doing much for us on primer-app, besides ensuring everyone is starting with the same Nix shell. It's pretty obvious to me at this point that nobody really uses Nix for building JavaScript/TypeScript applications.

@dhess
Copy link
Member Author

dhess commented May 25, 2022

Once #358 is merged, it's questionable whether we should be running pre-commit-checks using Nix, except for maybe the Nix formatting checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked/upstream ❌ Blocked by upstream issue bug 🐞 A confirmed bug tracking This is a tracking issue
Projects
None yet
Development

No branches or pull requests

1 participant