chore(nodejs): Upgrade Chromatic to 7.0. #857
Conversation
Note: `pnpm build-storybook` is quite slow now as compared to v6, but hopefully upstream will improve this over time. Storybook now includes a "Docs" panel for each component. Some of our components don't work with this new panel (e.g., `FloatingToolbar` doesn't appear), but I don't think this is reason enough not to upgrade. We can fix these as needed. The individual component panels all seem to work correctly, in any case.
|
Yikes, the Storybook build times on the GitHub Action are absolutely terrible, much worse than I'm getting locally (which is already quite bad as compared to v6). I've filed an issue upstream: edit: An upstream fix is coming (storybookjs/storybook#22013), but I was able to work around it in the meantime. Building the Storybook is now actually faster than before. |
|
There also appear to be some issues with the UI tests check on Chromatic. I'll look into it. (Edit: sent email to support. They don't seem to know what's going on but say they'll look into it.) |
See: storybookjs/storybook#22011 storybookjs/storybook#22013 Once the latter PR is included in a Storybook release, we can undo this workaround.
dhess
force-pushed
the
dhess/chromatic-upgrade
branch
from
60e4bc7
to
992cc97
Compare
|
According to Chromatic support, the UI test artifacts may be due to the (previously) really slow Storybook build and the UI test timing out, so let's merge this and see what happens with the next PR. They gave me some possible workarounds if that doesn't resolve the issue. |
Storybook now includes a "Docs" panel for each component. Some of our
components don't work with this new panel (e.g.,
FloatingToolbardoesn't appear), but I don't think this is reason enough not to
upgrade. We can fix these as needed. The individual component panels
all seem to work correctly, in any case.