feat: Better example program re-use in tests. #461
Conversation
dhess
force-pushed
the
dhess/more-dsl-improvements
branch
6 times, most recently
from
05929c0 to
e70e297
Compare
dhess
force-pushed
the
dhess/more-dsl-improvements
branch
from
e70e297 to
6a93cb3
Compare
dhess
force-pushed
the
dhess/more-dsl-improvements
branch
3 times, most recently
from
8d491ba to
ee3466e
Compare
dhess
force-pushed
the
dhess/more-dsl-improvements
branch
from
5cca2a8 to
52cab05
Compare
dhess
changed the title
mkASTDef helper function.
dhess
force-pushed
the
dhess/more-dsl-improvements
branch
from
52cab05 to
92bd49d
Compare
|
There’s more I want to do to make program/app creation more ergonomic from Haskell, but this seems like a good place to cap off this particular PR. |
|
Note: this has been rebased on #497, so you can ignore the first few commits. |
| { appProg = testProg | ||
| , appInit = NewApp |
There was a problem hiding this comment.
It may be worth noting that this appInit is a lie (and thus undo will not work with this App). I suspect this also happens in other places we make a test App. The lie is benign since we will never look at this field!
IIRC you had plans shortly to revisit how we encode the "initial app", which would fix this?
There was a problem hiding this comment.
Yes, that functionality is next in my queue. This PR is some groundwork for that.
| "^Primer.Database.Rel8.Rel8Db.runRel8Db" | ||
| ] | ||
| ignoreRoots = | ||
| [ "^Primer.Core.Utils.mkASTDef" |
There was a problem hiding this comment.
I'm a bit surprised you did not end up using this helper that has just been introduced
There was a problem hiding this comment.
Me too. In retrospect, I wouldn't have bothered with it, but this PR has been in flight for several weeks and sometimes that's just how development goes.
I thought about going back and rewriting everything from the start, knowing that I would not need it in the end, but that would require a lot of busy work, so I had 2 practical choices: add a final commit to remove it, now that it's no longer needed, or keep it around in case it's useful in the future. I chose the latter, but I can do the former if you prefer.
There was a problem hiding this comment.
That sounds fine to me. A third choice is to use it when defining the comprehensive example, but that may be slightly awkward code.
dhess
force-pushed
the
dhess/more-dsl-improvements
branch
from
92bd49d to
214927a
Compare
This doesn't save much typing, but the `NonEmptyList` constructor name is annoyingly hard to remember.
We parameterize the `Primer.Examples` functions over module names, to make them easier to reuse in tests, example DSL programs, etc.
Previously, we used this test definition verbatim in 2 different places.
dhess
force-pushed
the
dhess/more-dsl-improvements
branch
from
214927a to
b93078f
Compare
No description provided.