-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split a testing library #625
Conversation
Notes for reviewers: We have discussed doing something like this a while ago. I am now doing it so I can use generators in This PR is only moving code around, and I suspect is more bikeshed-able than the actual testing PR -- I am happy to have suggestions on better module/file organisation etc! |
@dhess I don't think any nix changes are needed as haskell.nix should take care of everything, but could you confirm? |
I don't see anything in here that would require Nix changes, no. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been wanting this for awhile, thanks!
dc0ce93
to
e28b192
Compare
4162911
to
8ef0fb1
Compare
This is rebased and ready to go, except: Locally, when building |
We split hedgehog generators, and some tasty glue into its own library (as part of the Primer package). We split these out to enable reuse of generators between primer and primer-service in the future. Note that whilst internal libraries are supported with cabal-version: 2.4, the ability to set visibility is only available from 3.0.
8ef0fb1
to
0492962
Compare
This seems to be a haskell.nix devShell + cabal issue: I only see it in a haskell.nix devShell and cannot reproduce with a nixos ghc+cabal. The upstream issue seems to be input-output-hk/haskell.nix#662 |
We split hedgehog generators, and some tasty glue into its own library
(as part of the Primer package). We split these out to enable reuse of
generators between primer and primer-service in the future. Note that
whilst internal libraries are supported with cabal-version: 2.4, the
ability to set visibility is only available from 3.0.