Remove icon next to add-on entry #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBH, I really like the icon to highlight it is basically a shortcut / navigation to somewhere else. |
|
The entry does not navigate and is definitely not a shortcut, it opens a dialog. |
|
Yes, but then navigates to the add-ons 😄, but your call reg. the icon. BTW: Does the auto navigation after 10 seconds in that dialog work for you? Does not work on my end (progress bars goes to 10, but nothing happens). If it is not a known issue, I can raise one here. |
|
I know about it, but fixing it is low on my list since no one should actually ever see that dialog at all. |
|
This pull request introduces 1 alert when merging d2713c6 into 6af39a1 - view on LGTM.com new alerts:
|
ludeeus
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially too hacky, but I used
56pxsince that is the width of the icon plus its margin on the right.Before:
After:
Only tested via browser dev tools.