Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory required for logger #1638

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Reduce memory required for logger #1638

merged 1 commit into from
Nov 6, 2020

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Nov 6, 2020

@bdraco bdraco marked this pull request as draft November 6, 2020 19:24
@ludeeus
Copy link
Member

ludeeus commented Nov 6, 2020

It has a fixed number of instances, so it's not a leak?

@bdraco bdraco changed the title Fix memory leak in logger Reduce memory required for logger Nov 6, 2020
@bdraco
Copy link
Contributor Author

bdraco commented Nov 6, 2020 •
edited
Loading

It has a fixed number of instances, so it's not a leak?

Right. I'll adjust the title as its really about reducing the number of logger objects in memory in this case as new repos are added they increase over time.

Testing: Reduced # of HassLogger in ram objects from 1343 to 436

@ludeeus
Copy link
Member

ludeeus commented Nov 6, 2020

There is not really a good reason to have so many, it easy to identify, but that can be done with variables as well, i should not need more than 1-10 different instances.

Will clean that some other time (actually thought about that earlier today)

@bdraco bdraco marked this pull request as ready for review November 6, 2020 19:39
ludeeus
ludeeus approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ludeeus ludeeus merged commit a90f448 into hacs:main Nov 6, 2020
@ludeeus ludeeus mentioned this pull request Nov 7, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ludeeus ludeeus ludeeus approved these changes

Assignees
No one assigned
Labels
pr: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @ludeeus