Avoid polling in the sensor #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listen for the hacs/status status event instead
bdraco
force-pushed
the
listen_for_status
branch
from
00cef55
to
03a4119
Compare
ludeeus
reviewed
Nov 14, 2020
| async def async_added_to_hass(self) -> None: | ||
| """Register for status events.""" | ||
| self.async_on_remove( | ||
| self.hass.bus.async_listen("hacs/status", self._update_and_write_state) |
There was a problem hiding this comment.
This is overkill? that even is used too much
Currently, I don't think there are any good events for this, but in general, I like the idea.
There was a problem hiding this comment.
Ideally there would be a specific dispatch/event when repository changes pending_update status, but this seemed better than polling every 15 seconds since this effectively disappears from the profile in most cases:
There was a problem hiding this comment.
I want to add a task/job manager, that could create a separate event when done with the different tasks, but until then I guess status is fine 👍
ludeeus
approved these changes
Nov 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen for the hacs/status status event instead