Fix Non-thread-safe operation invoked on an event loop other than the current one #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… current one `2021-10-31 15:05:52 ERROR (MainThread) [custom_components.hacs] Task setup_frontend failed: Non-thread-safe operation invoked on an event loop other than the current one`
ludeeus
reviewed
Oct 31, 2021
| @@ -18,7 +18,7 @@ class Task(HacsTask): | |||
|
|
|||
| stages = [HacsStage.SETUP] | |||
|
|
|||
| def execute(self) -> None: | |||
| async def async_execute(self) -> None: | |||
There was a problem hiding this comment.
Suggested change
| async def async_execute(self) -> None: | |
| def execute(self) -> None: |
This task only reset and add elements to a set, that is safe?
There was a problem hiding this comment.
It is likely safe, but is less risky to do in the main thread if we can so we don't have to think about if the GIL is making the structure safe or not.
ludeeus
approved these changes
Oct 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-10-31 15:05:52 ERROR (MainThread) [custom_components.hacs] Task setup_frontend failed: Non-thread-safe operation invoked on an event loop other than the current one