Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust link to FAQ #2591

Merged
merged 5 commits into from
Apr 3, 2022
Merged

Adjust link to FAQ #2591

merged 5 commits into from
Apr 3, 2022

Conversation

CloCkWeRX
Copy link
Contributor

Fixes #2590

ludeeus
ludeeus requested changes Apr 3, 2022
View reviewed changes
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not make sense to go to /addons here.

@CloCkWeRX
Copy link
Contributor Author

So, I put /addons here as it then mirrors the homepage:
image

Happy to adjust to whatever is best, but might also need to adjust the homepage behaviour too.

@ludeeus
Copy link
Member

ludeeus commented Apr 3, 2022

Website was wrong, adjusted here hacs/documentation@d0972e9

ludeeus
ludeeus reviewed Apr 3, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
info.md Outdated Show resolved Hide resolved
CloCkWeRX and others added 2 commits April 3, 2022 19:00
@CloCkWeRX @ludeeus
Update README.md
1c78738 
Co-authored-by: Joakim Sørensen <hi@ludeeus.dev>
@CloCkWeRX @ludeeus
Update info.md
6eb3381 
Co-authored-by: Joakim Sørensen <hi@ludeeus.dev>
@CloCkWeRX
Copy link
Contributor Author

Nice. Good to go I think!

@ludeeus ludeeus merged commit 645c396 into hacs:main Apr 3, 2022
@ludeeus ludeeus added this to the next milestone Apr 3, 2022
@CloCkWeRX CloCkWeRX deleted the patch-1 branch April 3, 2022 10:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ludeeus ludeeus ludeeus approved these changes

Assignees
No one assigned
Labels
pr: refactor
Projects
None yet
Milestone
1.24.3
Development

Successfully merging this pull request may close these issues.

Broken link to FAQ in /hacs/entry
2 participants
@CloCkWeRX @ludeeus