Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use authed method to get manifest file #4210

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Mause
Copy link

@Mause Mause commented Nov 19, 2024

Removed the duplicate method get_integration_manifest. This resolves auth issues I was seeing with a private repo.

This does mean a duplicate call being made though - is this something I should look to resolve?

@ludeeus
Copy link
Member

ludeeus commented Nov 19, 2024

FYI: I will not accept this for 2 reasons:

  • Private repositories are not something that is supported.
  • This will add a API request, instead of hitting CDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants