Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI) Update F* version to fix mlkem CI job #1212

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

maximebuyse
Copy link
Contributor

This PR updates the F* version used by the ML-KEM CI job. The job was failing recently (see for example https://github.com/hacspec/hax/actions/runs/12482298578/job/34836176279, because of a syntax error). Using a more recent F* fixes this (https://github.com/hacspec/hax/actions/runs/12483217088/job/34838637301)

Copy link
Contributor

@karthikbhargavan karthikbhargavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the same version as the one used on the libcrux CI? keeping the two versions in sync would be ideal.

@maximebuyse
Copy link
Contributor Author

The version is the same as libcrux, let's merge.

@maximebuyse maximebuyse enabled auto-merge January 6, 2025 09:57
@maximebuyse maximebuyse added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit b2f930b Jan 6, 2025
14 of 15 checks passed
@maximebuyse maximebuyse deleted the fix-mlkem-ci-fstar branch January 6, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants