fix(engine/fstar): fix super typeclasses attributes #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W95Psp
force-pushed
the
fix-super-tcs
branch
from
725d5f4
to
66a1a6e
Compare
The PR #902 was reverted by #909 because #902 was generated redundant fields names in classes for super clauses, which is a problem for F*. This PR changes the naming scheme of super clauses for typeclasses in F*. Those names now take into account the trait name. The super trait names are now a 5 characters base 62 encoding of the hash of the predicate ID concatenated with the trait name. Fixes #630.
W95Psp
force-pushed
the
fix-super-tcs
branch
from
66a1a6e
to
994b9c0
Compare
|
I need to debug, something is off |
|
Status: I'm getting back to proof work, but we need to address this issue, and this PR is a good start at it. |
|
Ah, yes, I was almost certain I added those goals already: that was done in branch main...add-infos-impl |
|
This PR has been marked as stale due to a lack of activity for 60 days. If you believe this pull request is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #902 was reverted by #909 because #902 was generated redundant fields names in classes for super clauses, which is a problem for F*.
This PR changes the naming scheme of super clauses for typeclasses in F*. Those names now take into account the trait name. The super trait names are now a 5 characters base 62 encoding of the hash of the predicate ID concatenated with the trait name.
Fixes #630.