Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug nchains resclust #332

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Bug nchains resclust #332

merged 3 commits into from
Aug 31, 2023

Conversation

mgiulini
Copy link
Collaborator

Closes #331

@mgiulini mgiulini self-assigned this Aug 31, 2023
@mgiulini mgiulini requested a review from VGPReys August 31, 2023 10:01
VGPReys
VGPReys approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@VGPReys VGPReys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Should a supplementary hint be provided to the user ?
such as: Please check your input pdb file for xxxxx

@mgiulini
Copy link
Collaborator Author

you're right, we should tell the user to use the --chain option in the error message.

@mgiulini mgiulini merged commit ad9dd8e into main Aug 31, 2023
@mgiulini mgiulini deleted the bug_nchains_resclust branch August 31, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VGPReys VGPReys VGPReys approved these changes

Assignees

@mgiulini mgiulini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgiulini @VGPReys