-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prodigy]
scoring module
#1069
base: main
Are you sure you want to change the base?
[prodigy]
scoring module
#1069
Conversation
I'm guessing you are still working on it - but keep in mind prodigy is also python so it should be used a library, not as a subprocess call |
maybe indeed a good idea. |
not an idea, it's how it should be done. also keep in mind this could cause a dependency deadlock, so add it as an optional dependency in pyproject.toml |
It's already not possible to install both |
so add it as an optional dependency in pyproject.toml |
@VGPReys I've made your life easier by updating the max/min python versions of prodigy and prodigy-lig to match the ones here - so 3.9, 3.10, 3.11 and 3.12, check the latest releases |
Nice, indeed will simplify the process |
Adding this dependencies will be easier after #1099 |
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines.
Checklist
Summary of the Pull Request
Add a new scoring module
[prodigy]
.todo:
pip install prodigy-prot prodigy-lig
)