-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correction of the usage of DSSP in the topocg module #1090
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvhonorato
reviewed
Oct 9, 2024
rvhonorato
reviewed
Oct 9, 2024
rvhonorato
reviewed
Oct 9, 2024
rvhonorato
reviewed
Oct 9, 2024
rvhonorato
reviewed
Oct 9, 2024
rvhonorato
reviewed
Oct 9, 2024
rvhonorato
reviewed
Oct 14, 2024
rvhonorato
reviewed
Oct 14, 2024
rvhonorato
reviewed
Oct 17, 2024
rvhonorato
reviewed
Oct 18, 2024
rvhonorato
reviewed
Oct 18, 2024
rvhonorato
reviewed
Oct 18, 2024
rvhonorato
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still somethings to be improved but good enough for now
should I merge the pool request ? |
Go for it! |
Thanks :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines.
Checklist
Summary of the Pull Request
Here, I adapt the code to produce DSSP usable pdb files and remove the usage of the DSSP function from the BioPython library, instead using the command line version.
Related Issue
Not related to an issue
Additional Info
The warning "No SS definition found for residue: ..." was removed, since if DSSP is installed and works, a secondary structure will be applied.
I will look into the Codacy reports issues with the aa2cg.py script for a following pull request.