Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[caprieval] comparisons against multiple references #1136

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Nov 8, 2024

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

This PR in made to handle comparisons with multiple references.

This is performed by turning on the parameter multiple_references = true (default false).
In this scenario, reported values in capri_ss.tsv are the ones obtained against the best reference.

If multiple_references = false (default), the first reference will be used as reference.

I had to add the __eq__ and __lt__ methods to the CAPRI class, so comparisons could be performed by functions/methods such as sorted([CAPRI, CAPRI]) or [CAPRI, CAPRI].sort().

Related Issue

#1133

@VGPReys VGPReys added enhancement Enhancing an existing feature of adding a new one feature New feature request m|caprieval Improvements in caprieval module labels Nov 8, 2024
@VGPReys VGPReys requested a review from mgiulini November 8, 2024 12:00
@VGPReys VGPReys self-assigned this Nov 8, 2024
@VGPReys VGPReys requested a review from mgiulini December 9, 2024 09:44
@VGPReys VGPReys merged commit 91908d0 into multi-ref-caprieval Dec 9, 2024
4 checks passed
@VGPReys VGPReys deleted the multi-ref-comparisons branch December 9, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one feature New feature request m|caprieval Improvements in caprieval module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants