Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed capri columns #805

Merged
merged 1 commit into from
Feb 19, 2024
Merged

changed capri columns #805

merged 1 commit into from
Feb 19, 2024

Conversation

mgiulini
Copy link
Contributor

@mgiulini mgiulini commented Feb 19, 2024

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #804 by using the underscore character in capri ss files.

@mgiulini mgiulini self-assigned this Feb 19, 2024
@mgiulini mgiulini added the m|caprieval Improvements in caprieval module label Feb 19, 2024
@mgiulini mgiulini mentioned this pull request Feb 19, 2024
12 tasks
@mgiulini mgiulini marked this pull request as ready for review February 19, 2024 15:41
@mgiulini mgiulini merged commit b297c2f into main Feb 19, 2024
5 checks passed
@mgiulini mgiulini deleted the cluster_id branch February 19, 2024 16:36
sverhoeven added a commit to i-VRESSE/haddock3 that referenced this pull request Feb 20, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m|caprieval Improvements in caprieval module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consistent naming between both tsv files in capri
2 participants