-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter incompatibilities: Increase flexibility in incompatibilities handles. #991
Merged
rvhonorato
merged 12 commits into
main
from
986-validate_parameters_are_not_incompatible-ignoring-incompatible-value-refactor
Oct 1, 2024
Merged
Parameter incompatibilities: Increase flexibility in incompatibilities handles. #991
rvhonorato
merged 12 commits into
main
from
986-validate_parameters_are_not_incompatible-ignoring-incompatible-value-refactor
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- more flexible - can be used in other modules
VGPReys
added
execution
Related to execution modes, such as GRID, HPC, local, etc.
bug
Something isn't working
labels
Sep 2, 2024
12 tasks
sverhoeven
reviewed
Sep 2, 2024
rvhonorato
previously requested changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Held by #987
rvhonorato
previously approved these changes
Sep 11, 2024
rvhonorato
changed the base branch from
986-validate_parameters_are_not_incompatible-ignoring-incompatible-value
to
main
September 11, 2024 13:56
…-ignoring-incompatible-value-refactor
rvhonorato
previously approved these changes
Sep 11, 2024
…-ignoring-incompatible-value-refactor
VGPReys
changed the title
Proposing an other way to handle incompatibilities.
Increase flexibility in incompatibilities handles.
Sep 13, 2024
…-ignoring-incompatible-value-refactor
VGPReys
requested review from
rvhonorato,
mgiulini,
AnnaKravchenko and
rversin
September 23, 2024 09:30
rvhonorato
previously approved these changes
Sep 23, 2024
rvhonorato
approved these changes
Sep 26, 2024
VGPReys
changed the title
Increase flexibility in incompatibilities handles.
Parameter incompatibilities: Increase flexibility in incompatibilities handles.
Sep 26, 2024
…-ignoring-incompatible-value-refactor
mgiulini
approved these changes
Oct 1, 2024
rvhonorato
deleted the
986-validate_parameters_are_not_incompatible-ignoring-incompatible-value-refactor
branch
October 1, 2024 12:09
amjjbonvin
restored the
986-validate_parameters_are_not_incompatible-ignoring-incompatible-value-refactor
branch
October 1, 2024 14:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
tox
tests pass. Runtox
command inside the repository folder-test.cfg
examples execute without errors. Insideexamples/
runpython run_tests.py -b
Refactor the way incompatible parameters are handled and written.
Hopefully allows for more flexibility and usage outside of the global parameters.
Closes #986
How to write an incompatible parameter ?
How to read / write / understand it ?
parameter1
has an incompatibility when its value isvalue1_X
withparameter2=value_Y
.Also, if
parameter1
is taking the valuevalue1_Y
,parameter2
cannot be set tovalue2_X
.In this case, the default configuration file is fine, as
parameter2
is havingvalue2_X
.But if the user is putting
value2_Y
forparameter2
, an error is thrown !