Addressing Issue #1 (using vdiffr instead of checking against interna…

…l structure).
haiderstats · May 23, 2019 · 0e9ee90 · 0e9ee90
1 parent 493c56a
commit 0e9ee90
Show file tree

Hide file tree

Showing 14 changed files with 595 additions and 6 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -19,6 +19,7 @@ Suggests:
     ggplot2 (>= 3.0.0),
     reshape2 (>= 1.4.3),
     testthat,
+    vdiffr (>= 0.3.0),
     covr,
     knitr,
     rmarkdown

diff --git a/tests/figs/deps.txt b/tests/figs/deps.txt
@@ -0,0 +1,3 @@
+- vdiffr-svg-engine: 1.0
+- vdiffr: 0.3.0
+- freetypeharfbuzz: 0.2.5
diff --git a/tests/figs/plotcurves-is-consistent-with-previous-plots/manycurves.svg b/tests/figs/plotcurves-is-consistent-with-previous-plots/manycurves.svg
diff --git a/tests/figs/plotcurves-is-consistent-with-previous-plots/onecurve.svg b/tests/figs/plotcurves-is-consistent-with-previous-plots/onecurve.svg
diff --git a/tests/figs/plotcurves-is-consistent-with-previous-plots/onepinkcurve.svg b/tests/figs/plotcurves-is-consistent-with-previous-plots/onepinkcurve.svg
diff --git a/tests/figs/plotcurves-is-consistent-with-previous-plots/shortcurve.svg b/tests/figs/plotcurves-is-consistent-with-previous-plots/shortcurve.svg
diff --git a/tests/figs/testing-methods-for-mtlr-objects/baseplot.svg b/tests/figs/testing-methods-for-mtlr-objects/baseplot.svg
diff --git a/tests/testthat/1curve.rds b/tests/testthat/1curve.rds
diff --git a/tests/testthat/1curve_colored.rds b/tests/testthat/1curve_colored.rds
diff --git a/tests/testthat/curveshortx.rds b/tests/testthat/curveshortx.rds
diff --git a/tests/testthat/manycurves.rds b/tests/testthat/manycurves.rds
diff --git a/tests/testthat/plot.rds b/tests/testthat/plot.rds
diff --git a/tests/testthat/test-method.R b/tests/testthat/test-method.R
@@ -12,7 +12,8 @@ testthat::test_that("print and plot functions are consistent for basic survival
   data <- survival::lung
   mod <- mtlr(formula, data)
   expect_equal_to_reference(print(mod),"print.rds")
-  expect_equal_to_reference(plot(mod),"plot.rds" )
+  basePlot <- plot(mod)
+  vdiffr::expect_doppelganger("basePlot", basePlot)
 
   data <- survival::leukemia
   mod <- mtlr(formula, data)

diff --git a/tests/testthat/test-plotcurves.R b/tests/testthat/test-plotcurves.R
@@ -9,9 +9,12 @@ testthat::test_that("plotcurves function is consistent",{
   mod <- mtlr(formula,data)
   curves <- predict(mod)
   expect_warning(plotcurves(curves, index=  1:3, color = c("red","green")))
-
-  expect_equal_to_reference(plotcurves(curves), "1curve.rds")
-  expect_equal_to_reference(plotcurves(curves, color = "pink"), "1curve_colored.rds")
-  expect_equal_to_reference(plotcurves(curves, index = 1:20), "manycurves.rds")
-  expect_equal_to_reference(plotcurves(curves, xlim = c(0,20)), "curveshortx.rds")
+  oneCurve <- plotcurves(curves)
+  vdiffr::expect_doppelganger("oneCurve", oneCurve)
+  onePinkCurve <- plotcurves(curves)
+  vdiffr::expect_doppelganger("onePinkCurve", onePinkCurve)
+  manyCurves <- plotcurves(curves)
+  vdiffr::expect_doppelganger("manyCurves", manyCurves)
+  shortCurve <- plotcurves(curves)
+  vdiffr::expect_doppelganger("shortCurve", shortCurve)
 })