Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing errors about part features #5807

Merged
merged 10 commits into from
Sep 29, 2024
Merged

Fix typing errors about part features #5807

merged 10 commits into from
Sep 29, 2024

Conversation

huibosa
Copy link
Contributor

@huibosa huibosa commented Sep 29, 2024 •
edited
Loading

Description

  • Use "|" instead of Union for consistency
  • Fix type hint for CutExtrude and SolidExtrude
  • Fix type hint for Round to suppress type check error since edgeList and Sequence are two mutally exclusive parameters.
  • Change the type of member id to suppress __getitem__'s error
  • Add NDArray support for all functions in Material.py
  • Add timePoint parameter for FeatureOutputRequest

huibosa_macmini and others added 10 commits March 17, 2024 19:14
[bugfix]: Fix type hint errors
fa9f98c
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8ca9b45 
for more information, see https://pre-commit.ci
[revert]: Use '|' instead of Union
2c9c2bc
[revert]: undo some unwanted changes
3855d56
@haiiliin
Fix pre-commit errors
e9ee512
@huibosa
Merge branch 'haiiliin:2024' into bugfix
f7ad64f
@huibosa
Merge branch 'haiiliin:2024' into bugfix
47f1892
@huibosa
[typing]: Fix typing errors about part features
c1f99aa 
- Use "|" instead of Union for consistency
- Fix type hint for `CutExtrude` and `SolidExtrude`
- Fix type hint for `Round` to suppress type check error since
  `edgeList` and `Sequence` are two mutally exclusive parameters.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e64d0fe 
for more information, see https://pre-commit.ci
@huibosa
[typing]: Fix some type hint
6bd3f14 
- Change the type of member `id` to suppress `__getitem__`'s error
- Add NDArray support for all functions in Material.py
- Add `timePoint` parameter for `FeatureOutputRequest`
@haiiliin haiiliin added backport-to-all Backport to all branches typing Typing labels Sep 29, 2024
@haiiliin
Copy link
Owner

Thanks

@haiiliin haiiliin merged commit 2e02a2e into haiiliin:2024 Sep 29, 2024
8 checks passed
mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@huibosa @mergify
[typing] Fix typing errors about part features (#5807)
eac4d12 
Co-authored-by: huibosa_macmini <huibosa@email.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
(cherry picked from commit 2e02a2e)
@mergify mergify bot mentioned this pull request Sep 29, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@huibosa @mergify
[typing] Fix typing errors about part features (#5807)
ff486bb 
Co-authored-by: huibosa_macmini <huibosa@email.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
(cherry picked from commit 2e02a2e)
mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@huibosa @mergify
[typing] Fix typing errors about part features (#5807)
8d77fef 
Co-authored-by: huibosa_macmini <huibosa@email.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
(cherry picked from commit 2e02a2e)

# Conflicts:
#	src/abaqus/Material/Material.py
This was referenced Sep 29, 2024
Merged
Merged
mergify bot added a commit that referenced this pull request Sep 29, 2024
@mergify @huibosa
Fix typing errors about part features (backport #5807) (#5808)
bf377c8 
Co-authored-by: huibosa <78707242+huibosa@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 29, 2024
@mergify @huibosa
Fix typing errors about part features (backport #5807) (#5809)
6e47347 
Co-authored-by: huibosa <78707242+huibosa@users.noreply.github.com>
mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@huibosa @mergify
[typing] Fix typing errors about part features (#5807)
236ba11 
Co-authored-by: huibosa_macmini <huibosa@email.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
(cherry picked from commit 2e02a2e)

# Conflicts:
#	src/abaqus/Material/Material.py
@mergify mergify bot mentioned this pull request Sep 29, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@huibosa @mergify
[typing] Fix typing errors about part features (#5807)
d6f76eb 
Co-authored-by: huibosa_macmini <huibosa@email.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
(cherry picked from commit 2e02a2e)

# Conflicts:
#	src/abaqus/Material/Material.py
mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@huibosa @mergify
[typing] Fix typing errors about part features (#5807)
4c162f3 
Co-authored-by: huibosa_macmini <huibosa@email.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
(cherry picked from commit 2e02a2e)

# Conflicts:
#	src/abaqus/Material/Material.py
This was referenced Sep 29, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@huibosa @mergify
[typing] Fix typing errors about part features (#5807)
7ebd3e3 
Co-authored-by: huibosa_macmini <huibosa@email.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
(cherry picked from commit 2e02a2e)

# Conflicts:
#	src/abaqus/Material/Material.py
@mergify mergify bot mentioned this pull request Sep 29, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 29, 2024
@huibosa @mergify
[typing] Fix typing errors about part features (#5807)
fefdae0 
Co-authored-by: huibosa_macmini <huibosa@email.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
(cherry picked from commit 2e02a2e)

# Conflicts:
#	src/abaqus/Material/Material.py
@mergify mergify bot mentioned this pull request Sep 29, 2024
Merged
mergify bot added a commit that referenced this pull request Sep 29, 2024
@mergify @huibosa
@pre-commit-ci @haiiliin
Fix typing errors about part features (backport #5807) (#5810)
bb171c6 
Co-authored-by: huibosa <78707242+huibosa@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 29, 2024
@mergify @huibosa
@pre-commit-ci @haiiliin
Fix typing errors about part features (backport #5807) (#5811)
b496aed 
Co-authored-by: huibosa <78707242+huibosa@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Sep 29, 2024
@mergify @huibosa
@pre-commit-ci @haiiliin
Fix typing errors about part features (backport #5807) (#5812)
4d0be7f 
Co-authored-by: huibosa <78707242+huibosa@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
mergify bot added a commit that referenced this pull request Sep 29, 2024
@mergify @huibosa
@pre-commit-ci @haiiliin
Fix typing errors about part features (backport #5807) (#5813)
ce6b8de 
Co-authored-by: huibosa <78707242+huibosa@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
mergify bot added a commit that referenced this pull request Sep 29, 2024
@mergify @huibosa
@pre-commit-ci @haiiliin
Fix typing errors about part features (backport #5807) (#5814)
464e4ee 
Co-authored-by: huibosa <78707242+huibosa@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
mergify bot added a commit that referenced this pull request Sep 29, 2024
@mergify @huibosa
@pre-commit-ci @haiiliin
Fix typing errors about part features (backport #5807) (#5815)
b869320 
Co-authored-by: huibosa <78707242+huibosa@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-to-all Backport to all branches typing Typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huibosa @haiiliin