Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some type hint errors (backport #5816) #5817

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix some type hint errors (backport #5816) #5817

merged 1 commit into from
Sep 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 30, 2024

Description

Use Datum where DatumPlane or DatumAxis is required to surpress type checker errors in cases like the following ones:

            dp.Wire(
                sketchPlane=dp.datums[pf.id],
                sketchPlaneSide=C.SIDE1,
                sketchUpEdge=dp.datums[3],
                sketchOrientation=C.RIGHT,
                sketch=s,
            )

Use ValuesView[ReferencePoint] to surpress checker errors in cases like the following ones:

        dp.Set(referencePoints=dp.referencePoints.values(), name="SET-DIE-RFPTS")

This is an automatic backport of pull request #5816 done by Mergify.

@huibosa @mergify
[typing] Fix some type hint errors (#5816)
6c63e47 
Co-authored-by: huibosa_macmini <huibosa@email.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
(cherry picked from commit b056cf0)
@mergify mergify bot added 2023 backport Backport pull request created by Mergify labels Sep 30, 2024
@mergify mergify bot merged commit 4cc9425 into 2023 Sep 30, 2024
1 of 3 checks passed
@mergify mergify bot deleted the mergify/bp/2023/pr-5816 branch September 30, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2023 backport Backport pull request created by Mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huibosa