Reintroduce native button rendering and CSS system colors after NEW_THEME removal #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HEME removal This also adds an implementation to render the spinbuttons Currently there is no api in haiku to let the controllook draw this so this is adapted from AbstractSpinner
ghost
requested a review
from
ghost
commented
Jan 28, 2024
| float fgTint; | ||
| if (!isEnabled) | ||
| fgTint = B_DARKEN_1_TINT; | ||
| else if (fIsMouseDown) |
There was a problem hiding this comment.
else if (states.states().contains(ControlStates::States::Pressed))
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds an implementation to render the spinbuttons Currently there is no api in haiku to let the controllook draw this so this is adapted from AbstractSpinner
This is UNTESTED
My build computer for haikuwebkit doesn't wanna boot.