Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[batch] new networking prices arrive in GCP on February 1 2024 #13784

Closed
danking opened this issue Oct 5, 2023 · 1 comment · Fixed by #14190
Closed

[batch] new networking prices arrive in GCP on February 1 2024 #13784

danking opened this issue Oct 5, 2023 · 1 comment · Fixed by #14190
Assignees
@jigold
Labels
batch

Comments

@danking
Copy link
Contributor

danking commented Oct 5, 2023

What happened?

We don't have code to automatically update network prices. We should either add that code or manually update the prices.

Version

0.2.124

Relevant log output

No response
@danking danking added the chore Roughly: infrastructure or operations. label Oct 5, 2023
@danking danking added batch and removed chore Roughly: infrastructure or operations. labels Oct 23, 2023
@jigold
Copy link
Contributor

jigold commented Jan 22, 2024

I didn't realize there are two prices for spot instances versus standard instances. We can support both (we currently charge the non-preemptible price), but is that something we want to do? Should still be relatively straightforward.

https://cloud.google.com/vpc/pricing-announce-external-ips

@jigold jigold mentioned this issue Jan 22, 2024
Merged
danking pushed a commit that referenced this issue Feb 1, 2024
@jigold
[batch] Update IP Fee pricing for February 2024 price increase (#14190)
171b39d 
Fixes #13784 

Here's the GCP documentation:
https://cloud.google.com/vpc/pricing-announce-external-ips

We were previously billing the same IP-Fee for both spot and regular
instances. I changed it so we're billing for each instance type
accordingly.

Following #13542, I hard coded the new resource rates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jigold jigold

Labels
batch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[batch] Update IP Fee pricing for February 2024 price increase jigold/hail
2 participants
@danking @jigold