[compiler] Emit Let Bindings Iteratively
#14163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By the time we get to `Emit(?:Stream)?$`, all bindings of type TStream should have been: - inlined (if it has exactly one use), or - eliminated (if it has no uses) Note streams cannot have more than one use. Previously `Emit(?:Stream)?$` was written without this assumption and had to emit stream bindings recursively. This can lead to stack overflows for large numbers of let-bindings (eg benchmark `matrix-multi-write-nothing`). This change emits bindings iteratively with the assertion emit bindings may not be of type TStream.
ehigham
changed the title
LetsLets Bindings Iteratively
ehigham
changed the title
Lets Bindings IterativelyLet Bindings Iteratively
chrisvittal
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
Emit(?:Stream)?$would emit let bindings recursively, regardless of if that binding was used.If a stream is not used,
Emit(?:Stream)?$would define its missing labels, making emission recursive.This can lead to stack overflows for large numbers of let-bindings (and does so for the benchmark benchmark
matrix-multi-write-nothing).By not emitting unused streams, we can make let-binding emission iterative.