Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Security impact field in templates #14666

Merged
merged 4 commits into from
Sep 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .github/ISSUE_TEMPLATE/change-request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Configuration Change
description: Tracker issues for configuration changes
labels: [ needs-triage ]
body:
- type: textarea
id: description
attributes:
label: Description
description: What is the change?
validations:
required: true
- type: dropdown
id: security-impact
attributes:
label: Security Impact
description: Level of security impact of the change
options:
- No Impact
- Low
- Medium
- High
validations:
required: true
- type: textarea
id: security-impact-description
attributes:
label: Security Impact Description
description: If the impact is No Impact or Low, justify that rating. If the impact is Medium or High, describe the security impact and any mitigations.
validations:
required: true
- type: checkboxes
id: appsec-signoff
attributes:
label: Appsec Signoff
description: If the security impact is High, has the change been reviewed and approved by the Appsec team?
options:
- label: Reviewed and approved
required: false
20 changes: 20 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
### Change Description

Fixes #<issue_number>.

### Security Assessment

- [ ] This change has a high security impact
- [ ] Required: and the impact has been assessed and approved by appsec
- [ ] This change has a medium security impact
- [ ] This change has a low security impact
- [ ] This change has no security impact

Description of the security impact and necessary mitigations:

- For none/low impact: a quick one/two sentence justification of the rating.
- Example: "Docs only", "Low-level refactoring of non-security code", etc.
- For medium/high impact: provide a description of the impact and the mitigations in place.
- Example: "New UI text field added in analogy to existing elements, with input strings escaped and validated against code injection"

(Reviewers: please confirm the security impact before approving)