[batch][notebook] Ubiqutous use of timeouts #4811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, as far as I can tell, swagger-codgen providss no way to set a default timeout. Instead, I littered our code with explicit timeout arguments to k8s API calls. The best documentation of this feature of swagger-codegen that I have found is the PR that adds the feature: swagger-api/swagger-codegen#4173
tpoterba
approved these changes
Nov 20, 2018
Contributor
|
wait what, how did this merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, as far as I can tell, swagger-codgen providss no way
to set a default timeout. Instead, I littered our code with explicit
timeout arguments to k8s API calls.
The best documentation of this feature of swagger-codegen that I have
found is the PR that adds the feature:
swagger-api/swagger-codegen#4173
cc: @cseed, we should do this any time we add new k8s API calls.