Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance GStreamer Detection App with GUI and Improved Reliability #41

Closed

Conversation

chm10
Copy link

@chm10 chm10 commented Aug 24, 2024

Alternative #40 has more changes and can break other codes. Need someone test another all functionality is ok.

  • Implement Gtk-based GUI for video display
  • Add watchdog mechanism to monitor and restart pipeline if needed
  • Improve RTSP connection handling with retry mechanism
  • Implement logging for better debugging and monitoring
  • Refactor pipeline creation and management for better modularity
  • Add error handling and graceful shutdown procedures
  • Optimize video processing with threading and improved buffer management
  • Enhance user interface with custom drawing area for video display
  • Implement window close event handling for proper application shutdown

Disclaimer:
I am not the owner or maintainer of this project. This pull request is a suggested solution based on
the information available in issue #39. It is provided "as is", without warranty of any kind, express
or implied. The project maintainers should review and test these changes thoroughly before considering
implementation. I'm open to feedback and further modifications if needed.

- Implement Gtk-based GUI for video display
- Add watchdog mechanism to monitor and restart pipeline if needed
- Improve RTSP connection handling with retry mechanism
- Implement logging for better debugging and monitoring
- Refactor pipeline creation and management for better modularity
- Add error handling and graceful shutdown procedures
- Optimize video processing with threading and improved buffer management
- Enhance user interface with custom drawing area for video display
- Implement window close event handling for proper application shutdown
@giladnah
Copy link
Contributor

@chm10 This is excellent work that I would be happy to merge. After running your code, I now understand what you meant by 'video hangs'—this happens when the file reaches the end, right?

I can't merge your code as-is because many of the remarks were removed, and I believe the correct place for your added functionality is in the GStreamerApp class in hailo_rpi_common.py. This way, all applications can benefit from it.

Please let me know if you'd like to make these changes yourself (and get your code merged with our extreme gratitude), or if you'd prefer us to handle it.

Once again, your contribution is highly appreciated.

@giladnah
Copy link
Contributor

Note that the initial video window remains open and you open a new one after restarting the pipeline.

@chm10
Copy link
Author

chm10 commented Aug 25, 2024

I can't merge your code as-is because many of the remarks were removed, and I believe the correct place for your added functionality is in the GStreamerApp class in hailo_rpi_common.py. This way, all applications can benefit from it.

I notice that will better back some changes to rollbacks remarks. I will transfer the modifications to the common class.

Please let me know if you'd like to make these changes yourself (and get your code merged with our extreme gratitude), or if you'd prefer us to handle it.

I have uncommits changes, I am testing, yet. And will upload after test some test cases. I only change to run the RTSP video.

Note that the initial video window remains open and you open a new one after restarting the pipeline.

I already have uncommited solution for this problem. I will need put another fuction to solve this issue. But after this will run without problem even this streamming ends. The user cannot close by Ctrl + C or D or X will lock the resource and will be release after reboot, but will work if someone close the application in the right way.

@giladnah
Copy link
Contributor

giladnah commented Sep 4, 2024

@chm10 this code runs on X86 but not on the RPi because it uses wayland not x11

@chm10
Copy link
Author

chm10 commented Sep 4, 2024

Yes, I use ssh access from x86 I mentioned in the issue.

@giladnah
Copy link
Contributor

giladnah commented Sep 5, 2024

I've added a 'rewind' feature in the new release. This should cover the video issues. Regarding GUI we must support all platforms. I'd be very happy to see you UI as a community project, you can publish it in our community.

@hailocs hailocs closed this Sep 5, 2024
@chm10 chm10 deleted the feature/rtsp-compatibility-39-alternative branch September 15, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants