Feature/restrict query deletion #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codlydodly
commented
Aug 26, 2014
Codlydodly
commented
- The delete button now works!
- Only available to those with the permission to edit queries.
- Only deletes a query if it is not being used in a dashboard.
- Queries can be deleted from either /queries or /query/query_id
…rything really really slow
…n delete any query regardless of wether it is being used or not
…r it to work from /queries is in place
| } | ||
| var dateFormatter = function(value) { | ||
| if (!value) return "-"; | ||
| return value.format("DD/MM/YY HH:mm"); |
There was a problem hiding this comment.
So you can compress this into a single line using the ternary operator, like this:
return value ? value.format("DD/MM/YY HH:mm") : "" ;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.